Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove StoryIndexer in favor of Indexer #25343

Closed
Tracked by #25331
yannbf opened this issue Dec 27, 2023 · 1 comment · Fixed by #25468
Closed
Tracked by #25331

Remove StoryIndexer in favor of Indexer #25343

yannbf opened this issue Dec 27, 2023 · 1 comment · Fixed by #25468
Assignees
@yannbf

Comments

@yannbf
Copy link
Member

yannbf commented Dec 27, 2023 •
edited
Loading

It's unclear whether to remove the deprecatedStoryIndexer in Storybook 8:

storybook/code/lib/types/src/modules/indexer.ts

Line 84 in 49ef8fa

export type StoryIndexer = Indexer | DeprecatedIndexer;

storybook/code/lib/types/src/modules/core-common.ts

Line 524 in 3b94da1

* @deprecated use {@link experimental_indexers} instead

@shilman please let us know whenever you can, especially if there are extra migration notes needed 🙏
@yannbf yannbf mentioned this issue Dec 27, 2023
Closed
@shilman
Copy link
Member

shilman commented Dec 28, 2023 •
edited
Loading

Yes Indexer only from 8.0 please! cc @JReinhold

@yannbf yannbf changed the title Determine whether to remove StoryIndexer in favor of Indexer Remove StoryIndexer in favor of Indexer Dec 28, 2023
@yannbf yannbf self-assigned this Jan 4, 2024
@yannbf yannbf mentioned this issue Jan 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yannbf yannbf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Core: Remove storyIndexers in favor of experimental_indexers storybookjs/storybook
2 participants
@shilman @yannbf