Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: Audit SB8 removals in the API docs #25847

Closed
shilman opened this issue Jan 31, 2024 · 2 comments · Fixed by #26326
Closed

[Documentation]: Audit SB8 removals in the API docs #25847

shilman opened this issue Jan 31, 2024 · 2 comments · Fixed by #26326
Assignees
Milestone

Comments

@shilman
Copy link
Member

shilman commented Jan 31, 2024

Describe the problem

I was just looking at an issue related to mdxSource and did a search for it in our codebase to verify that it had been removed in v8. It has been completely removed, but there is still a single reference in the docs:

### `mdxSource`
(⛔️ **Deprecated**)
Type: `string`
Provides source to display. Use [`source.code`](#source) instead.

Looking around in that file, it looks like there are other v8 removals that are also still present in the docs. Somebody should do an audit and make sure that everything that we removed from code in v8 has also been removed from the docs.

Additional context

No response

@shilman
Copy link
Member Author

shilman commented Jan 31, 2024

@JReinhold pointed out that the "deprecations & removals" documentation request is still WIP, so hopefully that obviates this issue.

@jonniebigodes
Copy link
Contributor

For context, the APIs for the Doc Blocks were already addressed, mostly during the work towards the beta by the team. The one referenced here was already removed with #25855. However, there's still a lingering reference to the storiesOf that is currently being addressed in a pull request that I've pushed, and I'm waiting on feedback. If there were any APIs for addons, that should have been addressed with the beta release, to which I asked for for a sanity check and to the best of my knowledge they were removed. If there's any lingering ones, they should have been thoroughly vetted previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants