-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular Knobs changing property name to lower case #2641
Labels
Comments
Is this behavior seems to not exist in React, I wonder why this was added.. Can you remember why this was added @alterx ? |
It's probably a leftover from the first implementation (problems of having to duplicate code 😢 ), right now I can't think of a justification for this. Will look into it. |
Awesome! thanks for the fast response guys :) |
Fix released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue details
When using knobs in Angular the property names are converted to lower case inside KnobWrapperComponent.knobChanged. This is making it impossible to use a knob on a property with a camel cased name
https://github.com/storybooks/storybook/blob/master/addons/knobs/src/angular/helpers.js#L76
Steps to reproduce
When I console log the the ngOnChanges object for the following, the property name changed is "buttontype" instead of "buttonType"
Please specify which version of Storybook and optionally any affected addons that you're running
The text was updated successfully, but these errors were encountered: