Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon-a11y] Allow Configuration of aXe #2830

Closed
codingmatty opened this issue Jan 24, 2018 · 5 comments
Closed

[addon-a11y] Allow Configuration of aXe #2830

codingmatty opened this issue Jan 24, 2018 · 5 comments

Comments

@codingmatty
Copy link

Issue details

We use aXe along with custom rules and checks to comprehensively check our components for accessibility issues. We also override some of aXe's rules locally if we find any inconsistencies.

It would be really nice if we could pass our configuration into the a11y add-on for storybook, so all of our custom rules and checks are displayed.

Instead you run only the default configuration and nothing more: https://github.com/storybooks/storybook/blob/5143028caf7e64ca4307ab2e56621d8c66fe4576/addons/a11y/src/components/WrapStory.js#L40

@jbovenschen
Copy link
Member

I am the original author of this plugin, I know that this could be a bit of an issue, it would be cool if we could just pass the configuration within the decorator, I'm currently not actively using storybook or this plugin, but would like to review any PR for this.

@stale
Copy link

stale bot commented Mar 13, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Mar 13, 2018
@wuweiweiwu
Copy link
Member

I can pick this up! I'll work on it this week

@Hypnosphi
Copy link
Member

Released as 4.0.0-alpha.0

@stale
Copy link

stale bot commented Apr 19, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants