Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Svelte v5.17.0 breaks args/Controls reactivity #30223

Closed
JReinhold opened this issue Jan 9, 2025 · 1 comment
Closed

[Bug]: Svelte v5.17.0 breaks args/Controls reactivity #30223

JReinhold opened this issue Jan 9, 2025 · 1 comment

Comments

@JReinhold
Copy link
Contributor

JReinhold commented Jan 9, 2025

Describe the bug

After upgrading Svelte to v5.17.0, changing args in the Controls panel have no effect on the story. Clicking the force re-mount button will correctly show with the changed args, but that shouldn't be necessary.

Image

Reproduction link

Happens in any minimal Svelte+Vite sandbox, any story.

Still trying to minimal reproduce this in a non-Storybook context, but haven't been successful yet.

Reproduction steps

  1. Have Svelte version ^5.17.0
  2. Navigate to a story
  3. Change some arg in the Controls panel
  4. See that it doesn't affect the rendered story
  5. Downgrade to Svelte version 5.16.6 and restart Storybook
  6. See it correctly work

Additional context

  • Using the $inspect(someProp) rune (or even $effect(...)) in the rendered component does trigger outputs to the console, so prop changes are propagated to the component, but for some reason those changes don't affect the DOM
  • The most likely culprint is chore: improve signal performance by reducing duplicate deps sveltejs/svelte#14945, as the other changes in the version don't appear to touch anything related (at least based on the change titles)
  • This happens in regular CSF too, so seems unrelated to the Svelte CSF addon
@JReinhold
Copy link
Contributor Author

Fixed by sveltejs/svelte#14964, released in Svelte 5.17.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant