-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preview-head.html is not rendered again in hot reload #3176
Comments
for the reproduction, it's not really easy in a codesandbox or fiddle you can reproduce with any storybook setup (having react, babel, .. all set up), add a here's a quick video: https://i.imgur.com/sR9KTQ6.gifv @ndelangen do you need a standalone reproduction repo for this issue? then I'll try to make one from one of the examples |
I couldn't reproduce using |
thanks! Will take a look if you can provide a reproduction repo 👍 . |
Ok, I found the issue I just need to avoid HtmlWebpackPlugin in storybook It was more weird in my actual repo, since storybook templates was loaded initially as you can see in the video, and then the webpack template was loaded instead. In this repo, it's only loaded the webpack template, even if I tried to keep the env as much similar as possible Thanks, closing, maybe there can be things, like warnings to add on storybook side in such a case |
steps
have a
preview-head.html
file at the root of storybook folderinsert
<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">
in it for testingin your stories add a story with
<span className="material-icons">close</span>
in it, this renders a cross icon, when the fonts are loadedIt works in the main storybook page, and even for that story (
&full=1
) if you reload, the fonts worksbut in development mode (I use
"storybook": "start-storybook -p 9001 -c .storybook",
) as soon as editing this particular story, it's re-rendered, and you see suddenlyclose
instead of a❌
, I guesspreview-head.html
is ignoredversion
The text was updated successfully, but these errors were encountered: