Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a handy link directly to iframe content #3652

Closed
wholesomedev opened this issue May 26, 2018 · 7 comments
Closed

Provide a handy link directly to iframe content #3652

wholesomedev opened this issue May 26, 2018 · 7 comments
Assignees
Milestone

Comments

@wholesomedev
Copy link

Sometimes I need to view components in an actual mobile device outside of Storybook.

Having a handy direct link to the iframe content, like

http://mystorybookwebsite.com/iframe.html?selectedKind=Homepage&selectedStory=Default

would be helpful.

@Hypnosphi
Copy link
Member

Looks like a nice feature to have, feel free to send a PR if you have some ideas how to present it in UI

For now you can use full screen mode (ctrl+shift+F, copy current URL)

@Primigenus
Copy link
Contributor

I created a HOC within the iframe that allows you to "pop out" the current view. But I did that because I did not want to make changes directly to Storybook. A solution where Storybook provides the ability to pop out would be good. However, if you directly load the iframe you lose the state from the knobs, and you need to make a way to get back into Storybook. So there may be a more complete solution here where the iframe isn't actually popped out but the surrounding UI is just hidden. I believe there is already such a feature under ctrl+shift+f (fullscreen), so perhaps the solution here is to make a mobile-friendly UI for what is currently only available to keyboard users by shortcut?

@Hypnosphi
Copy link
Member

Makes sense to me. I wonder what @ndelangen and @shilman think

@stale
Copy link

stale bot commented Jun 29, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jun 29, 2018
@ndelangen
Copy link
Member

I will make a bit in the UI for this.

@stale stale bot removed the inactive label Jul 26, 2018
@ndelangen ndelangen self-assigned this Jul 26, 2018
@stale stale bot added the inactive label Aug 16, 2018
@ndelangen ndelangen mentioned this issue Aug 27, 2018
82 tasks
@stale stale bot closed this as completed Sep 15, 2018
@Hypnosphi Hypnosphi added the todo label Sep 15, 2018
@Hypnosphi Hypnosphi reopened this Sep 15, 2018
@stale stale bot removed the inactive label Sep 15, 2018
@storybookjs storybookjs deleted a comment from stale bot Oct 13, 2018
@storybookjs storybookjs deleted a comment from stale bot Oct 13, 2018
@ndelangen ndelangen added this to the v5.0.0 milestone Oct 13, 2018
@shilman
Copy link
Member

shilman commented Jan 14, 2019

@prmichaelsen
Copy link

for posterity, looks like it works

ie http://localhost:6001/iframe.html?id=useviewportsize--default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants