Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook keyboard shortcuts overlap in IE/Edge and Firefox #403

Closed
MaDDmin opened this issue Aug 24, 2016 · 9 comments
Closed

Storybook keyboard shortcuts overlap in IE/Edge and Firefox #403

MaDDmin opened this issue Aug 24, 2016 · 9 comments

Comments

@MaDDmin
Copy link

MaDDmin commented Aug 24, 2016

That particular combination is taken on Firefox and opens a new private tab instead of toggling the Searchbox as it was meant to.

Here is the relation of Firefox shortcuts in which can be found that particular one: https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly?redirectlocale=en-US&redirectslug=Keyboard+shortcuts#w_windows-tabs

Control + Shift + P = private window
Control + Shift + L = new tab address bar

@ndelangen
Copy link
Member

So what should the new shortcut be?

@ndelangen ndelangen changed the title Ctrl + Shift + P shortcut not valid on Firefox Change (Ctrl + Shift + P) shortcut because it's not valid on Firefox Jul 7, 2017
@danielduan
Copy link
Member

Same problem in IE #1691

@danielduan danielduan changed the title Change (Ctrl + Shift + P) shortcut because it's not valid on Firefox Storybook keyboard shortcuts overlap in IE and Firefox Aug 26, 2017
@danielduan danielduan added the ui label Aug 26, 2017
@Hypnosphi
Copy link
Member

And Edge as well

@danielduan danielduan changed the title Storybook keyboard shortcuts overlap in IE and Firefox Storybook keyboard shortcuts overlap in IE/Edge and Firefox Aug 26, 2017
@Hypnosphi
Copy link
Member

As soon as we rename "left panel" to "stories panel" we can introduce Ctrl + Shift + S while keeping to support Ctrl + Shift + L for backward compatibility. For showing search panel, it seems quite natural to use Ctrl + Shift + F.

@Hypnosphi Hypnosphi self-assigned this Aug 31, 2017
@Hypnosphi Hypnosphi added this to the v3.3.0 milestone Aug 31, 2017
@Hypnosphi
Copy link
Member

Oh, Ctrl + Shift + F is reserved for fullscreen already.

@Hypnosphi Hypnosphi removed this from the v3.3.0 milestone Sep 1, 2017
@Hypnosphi
Copy link
Member

Here's a table with all the used Cmd/Ctrl + Shift + shortcut keys in major brawsers (sorted by usage data from caniuse), excluding text field shortcuts, and some highly contextual shortcuts:

⌘/Ctrl+Shift+ A B C D E F G H I J K L M N O P Q R S T U V W X Y Z
Chrome + + + + + + + + + +
Firefox + + + + + + + + + + + +
IE 11 + +
Safari + +
Edge + + + + +
Opera + + + + + + + + + +

Those keys are therefore safe for now: C E F G K O Q X Y. U is also quite safe, it's used only in Opera ("View source of active frame")
We're using F for fullscreen, and need to pick four of the remaining ones for other shortcuts instead of D L P J.

For search, we could use Q (stands for "query") As for panels, I can suggest using the key positions relative to F. Here's how available keys are laid out on standard keyboard:

Q E Y U O
(F) G K
X C

So here's my suggestion:

  • Q for search box
  • E for stories panel
  • C for addons panel
  • G for addons panel in right

@ndelangen what do you think?

@ndelangen
Copy link
Member

I like it @Hypnosphi ❤️

@stale
Copy link

stale bot commented Nov 14, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@dutzi
Copy link

dutzi commented Aug 13, 2018

@Hypnosphi Cmd+Shift+C is Chrome's Devtools Inspect Element shortcut :\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants