Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theming support #428

Closed
arunoda opened this issue Sep 5, 2016 · 6 comments
Closed

Add theming support #428

arunoda opened this issue Sep 5, 2016 · 6 comments

Comments

@arunoda
Copy link
Member

arunoda commented Sep 5, 2016

Add the ability to theme storybook as needed.
We should also carry a new theme with getstorybook.io look and feel.

@ghost
Copy link

ghost commented Oct 9, 2016

What about using react-with-styles by airbnb?

I have already used it together with aphrodite and its working really well.

@tuchk4
Copy link
Member

tuchk4 commented May 25, 2017

Any plans?)

@usulpro
Copy link
Member

usulpro commented Jun 26, 2017

We can add theming support as a separate feature on par with UI customization (#313, #1266)

I propose to start implementing theming via follows:

  • Add mantra module and API to @storybook/ui (Theming support #428 #1360)

  • Decide what parameters we'll include to themes (colors, styles, sizes). What the structure of theme object?

  • Create default themes (white Theming support #428 #1360, black)

  • Create the tool for themes development and API to support custom themes (on par with API for custom UI components which could support theming or not)

@ndelangen
Copy link
Member

My long-term goal is to migrate al UI components to a specialised package, and from the app allow addons to wrap any of these.

This will allow for custom placeholders, theme changes, data enrichment, custom ui behavior.

This work is in progress, but moving all components is a large task.

@stale
Copy link

stale bot commented Jan 18, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Jan 18, 2018
@stale
Copy link

stale bot commented Feb 2, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants