Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y addon should highlight violations tab by default #5595

Closed
domyen opened this issue Feb 15, 2019 · 1 comment
Closed

a11y addon should highlight violations tab by default #5595

domyen opened this issue Feb 15, 2019 · 1 comment
Assignees
Milestone

Comments

@domyen
Copy link
Member

domyen commented Feb 15, 2019

Describe the bug
a11y add-on should highlight “violations” tab when it loads. It currently shows the content for this tab but does not highlight the tab until you click on it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a11y addon
  2. See that the violations content is shown
  3. But the violations tab is not highlighted (in blue)

Expected behavior
The violations tab should be highlighted

Screenshots
Bad
image

Good
image

@shilman
Copy link
Member

shilman commented Feb 19, 2019

Boo-yah!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.0-rc.2 containing PR #5646 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants