Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.0-rc.10] Switching stories results in breaking storybook #5852

Closed
daKmoR opened this issue Mar 4, 2019 · 5 comments
Closed

[5.0.0-rc.10] Switching stories results in breaking storybook #5852

daKmoR opened this issue Mar 4, 2019 · 5 comments
Labels
Milestone

Comments

@daKmoR
Copy link
Contributor

daKmoR commented Mar 4, 2019

Describe the bug
Switching between stories pretty fast or multiple times results in

Cannot read property 'nextSibling' of null

To Reproduce
Steps to reproduce the behavior:

git clone https://github.com/daKmoR/storybook-bug-5852.git
cd storybook-bug
yarn install
yarn storybook

# In storybook switch between stories a few times

Expected behavior
Working storybook.

Screenshots
storybook-bug

@daKmoR
Copy link
Contributor Author

daKmoR commented Mar 4, 2019

apparently, it has to do with this

  .add('Alternative Header asdf', () => {
    const el = document.createElement('div');
    el.innerText = 'something';
    return el;
  })

e.g. if you return a node and then you switch multiple times then it "breaks" with this "fatal" error and you are forced to do a hard reload.

@shilman
Copy link
Member

shilman commented Mar 11, 2019

Yo-ho-ho!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.4 containing PR #5868 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Mar 11, 2019
@daKmoR
Copy link
Contributor Author

daKmoR commented Apr 27, 2019

@shilman any chance this can be released for 5.0.x? or how far away is 5.1.x?

@shilman
Copy link
Member

shilman commented Apr 28, 2019

Will do. 5.1 a few weeks off

@shilman
Copy link
Member

shilman commented Apr 28, 2019

w00t!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.11 containing PR #5868 that references this issue. Upgrade today to try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants