Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SB5: Actions panel not clearing between stories #5932

Closed
asiacomeau opened this issue Mar 6, 2019 · 5 comments
Closed

SB5: Actions panel not clearing between stories #5932

asiacomeau opened this issue Mar 6, 2019 · 5 comments

Comments

@asiacomeau
Copy link

Describe the bug
After upgrading to Storybook 5, the Actions panel does not clear out when I switch between stories. This happens both when omitting clearOnStoryChange from storybook config, and when setting it to true.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a story that dispatches actions
  2. Cause the action to be dispatched (the action shows up in the actions panel)
  3. Go to another story and view the action panel
  4. The previous story's dispatched actions are still listed.

Expected behavior
The actions panel should be cleared out when I navigate to another story.

System:

  • OS: MacOS
  • Device: Macbook Pro 2018
  • Browser: chrome
  • Framework: react
  • Addons: actions (also info, knobs, storyshots)
  • Version: 5.0.0
@asiacomeau asiacomeau changed the title clearOnStoryChange actions config not being respected in SB5 SB5: Actions panel not clearing between stories Mar 6, 2019
@shilman shilman added this to the 5.0.x milestone Mar 6, 2019
@stale
Copy link

stale bot commented Mar 27, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 27, 2019
@benjamind
Copy link

This appears to be due to the options check on the actions stored in the actions panel. The default/global config is not being copied into each action, but the check is being done against the first action in the log. You can currently work around this by setting the config options on every action you log to have the clearOnStoryChange: true option, then the log will properly clear.

@stale
Copy link

stale bot commented Apr 22, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Apr 22, 2019
@stale
Copy link

stale bot commented May 22, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed May 22, 2019
@shilman
Copy link
Member

shilman commented Jun 13, 2019

Ooh-la-la!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.1.4 containing PR #6438 that references this issue. Upgrade today to try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants