Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display StorybookUI in your app in React Native #6214

Closed
amed opened this issue Mar 21, 2019 · 2 comments
Closed

Display StorybookUI in your app in React Native #6214

amed opened this issue Mar 21, 2019 · 2 comments

Comments

@amed
Copy link

amed commented Mar 21, 2019

The App that we are currently developing is migrated to latest versions of react native and storybook. (React-Native 0.59 with Storybook 5)

previous situation: Storybook4, running via $ react-native start --projectRoot storybook
current situation: Running StorybookUI via replacing projectRoot is not working anymore. (previous approach is not working)

Also as it is documentation describes:
Storybook for React Native in "Display StorybookUI in your app" section, this StorybookUI should be exported as the default component. Another idea is to use it somewhere inside the app which seems to me like an odd behaviour. The production bundle will have all unnecessary components and add-ons (possibly).

Is there a better way integrate Storybook in React Native?

@shilman
Copy link
Member

shilman commented Mar 22, 2019

@amed Pretty sure that suggestion is just for development mode. Nobody wants extra stuff in their production app? cc @benoitdion @Gongreg

@oblador
Copy link
Member

oblador commented Mar 26, 2019

It was a regression in the RN CLI, installing latest via yarn add @react-native-community/cli --dev should fix the issue.

@amed amed closed this as completed Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants