Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knobs panel renders off screen #6796

Closed
leanne2 opened this issue May 16, 2019 · 5 comments
Closed

Knobs panel renders off screen #6796

leanne2 opened this issue May 16, 2019 · 5 comments

Comments

@leanne2
Copy link

leanne2 commented May 16, 2019

Describe the bug
When using knobs panel the panel visually diappears despite all set up being correct. What is actually happening is then panel is rendering off screen. This can be seen by searching for react-draggable css class in the Chrome Dev Tools elements panel. This shows the panel is renderd but is rendered off screen at the top

To Reproduce
I am not entirely sure what triggers this, possibly a screen or browser window size change. It happens twice in two days

Expected behavior
It should not be possible for the knobs panel or its draggable edge to render off the visible part of the browser window

Screenshots
You can see the knobs panel is off screen
Screenshot 2019-05-16 at 11 16 29

System:

  • OS: MacOS
  • Device: Macbook Pro 2016
  • Browser: Chrome
  • Framework: Rect
  • Addons: Knobs
  • Version: 5.0.11;
@shilman
Copy link
Member

shilman commented May 16, 2019

Is it only knobs or is it all addons? Is it a duplicate of this? #6343

@shilman shilman added this to the 5.0.x milestone May 16, 2019
@leanne2
Copy link
Author

leanne2 commented May 16, 2019

@shilman I don't use other addons so cannot say if it is only knobs. Also it seemed today to simply hide the panel without out any reszing of the window. The browser window had been idle for a while, i refocusd it, the UI flickered (maybe due to a hot reload), then the panel disappears. To get it to re-appear i have to click "Change Addons orientation"

@shilman shilman modified the milestones: 5.0.x, 5.1.x Jun 5, 2019
@stale
Copy link

stale bot commented Jun 26, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jun 26, 2019
@stale
Copy link

stale bot commented Jul 26, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Jul 26, 2019
@shilman
Copy link
Member

shilman commented Jul 27, 2019

@leanne2 try doing localStorage.clear() in your browser console and then hard refresh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants