-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax highlighted code blocks render as gray on gray for unsupported languages in dark theme #6797
Comments
On a side note, I would be interested in getting an answer on #6144 as well (because this codeblock would be even better with proper highlighting. |
I'll see what I can do |
@ndelangen you might want to check out the changes @domyen made in the |
@stof Would you like to review my PR? |
Great Caesar's ghost!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-rc.0 containing PR #6814 that references this issue. Upgrade today to try it out! Because it's a pre-release you can find it on the Closing this issue. Please re-open if you think there's still more to do. |
@shilman I know this is a long closed ticket, but I'm trying to pass |
Ignore me! Found it here https://storybook.js.org/docs/react/writing-docs/mdx#syntax-highlighting |
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
```twig
when discovering the bug)Expected behavior
The code block is readable (as happens in light themes).
Screenshots
Code snippets
System:
Additional context
Note that disabling syntax highlighting (by removing the language on the codeblock) makes the text readable (but we miss the copy option then).
The text was updated successfully, but these errors were encountered: