-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Values changed using knobs don't update in a new tab view #6800
Comments
This is a little tricky without special-casing the eject button to know about knobs. However, I think it's a nice feature and should be possible. @ndelangen is there an easy way for knobs to override that button? |
This may be already fixed in the 5.1 beta? I'll check tomorrow |
I found that if the values are copied from the 'copy button' and then the user presses the But updating the knobs doesn't work. So I'll try and fix this today. |
Shiver me timbers!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-rc.1 containing PR #6817 that references this issue. Upgrade today to try it out! Because it's a pre-release you can find it on the Closing this issue. Please re-open if you think there's still more to do. |
Describe the bug
We use knobs a lot to check how components look with different translations/lengths of headlines, etc. which are then tested by UX. They prefer using the new tab view, without Storybook UI, however in that view, all options changed via knobs disappear and go back to the default view.
To Reproduce
Steps to reproduce the behavior:
Open canvas in new tab
Expected behavior
The expected behaviour is to see the component on its own, without Storybook UI, with properties changed according to knobs
System:
The text was updated successfully, but these errors were encountered: