Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: list style bleeds on stories components #6803

Closed
elevatebart opened this issue May 16, 2019 · 5 comments
Closed

Addon-docs: list style bleeds on stories components #6803

elevatebart opened this issue May 16, 2019 · 5 comments
Assignees
Milestone

Comments

@elevatebart
Copy link
Contributor

Describe the bug
Using addon-docs to showcase material powered Menu, I get an unwanted padding caused by the docs .12345xx ul{padding-left:30px;} coming from the docs.

To Reproduce

  1. install addon-docs alpha 8
  2. show case a component with a ul list in the docs tab
  3. it's padding-left will be too big

Expected behavior
The style of the docs should not bleed down on the components showcased

Screenshots
Normal

InTheDocsTab

System:

  • OS: Windows10
  • Browser: Mozilla Firefox 67.0 64bits
  • Framework: React
  • Addons: addon-docs
  • Version:5.2.0-alpha8
@elevatebart elevatebart changed the title Docs list padding bleeds on my components addon-docs: list style padding bleeds on stories components May 16, 2019
@elevatebart elevatebart changed the title addon-docs: list style padding bleeds on stories components addon-docs: list style bleeds on stories components May 16, 2019
@elevatebart elevatebart self-assigned this May 16, 2019
@shilman shilman added this to the 5.2.0 milestone May 16, 2019
@stale stale bot added the inactive label Jun 6, 2019
@shilman shilman removed the inactive label Jun 6, 2019
@storybookjs storybookjs deleted a comment from stale bot Jun 21, 2019
@shilman shilman changed the title addon-docs: list style bleeds on stories components Addon-docs: list style bleeds on stories components Jul 3, 2019
@anselmdk
Copy link

Same happening to me.
See the "edit" button, it should be 16px, but it's being overwritten by some CSS-in-JS styling.
Also margins and paddings seem to be affected.

2019-07-13_14h28_08
2019-07-13_14h28_41

@city41
Copy link

city41 commented Jul 30, 2019

I have also encountered this. I just upgraded to beta.18 to see if it's been fixed, but still see the issue.

In my case it's the same ul { padding-left: 30px } that OP is seeing.

@shilman
Copy link
Member

shilman commented Jul 31, 2019

That's why the issue is still open :trollface:

We're on it. High priority issue before the full release 👍

@shilman
Copy link
Member

shilman commented Aug 16, 2019

Shiver me timbers!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-beta.31 containing PR #7771 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman
Copy link
Member

shilman commented Aug 17, 2019

Jeepers creepers!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-beta.32 containing PR #7788 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants