Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Remove "primary" story #7378

Closed
shilman opened this issue Jul 11, 2019 · 1 comment
Closed

Addon-docs: Remove "primary" story #7378

shilman opened this issue Jul 11, 2019 · 1 comment
Labels
addon: docs BREAKING CHANGE
Milestone
5.2.0

Comments

@shilman
Copy link
Member

shilman commented Jul 11, 2019

There was an experimental { primary: true} to promote a story to the "primary" story for a component in docs. If primary wasn't set, Docs simply used the first story.

Let's remove primary to simplify the API, making the first story in the document is the first story for the component.
@shilman shilman added this to the 5.2.0 milestone Jul 11, 2019
@shilman shilman mentioned this issue Jul 11, 2019
Merged
@shilman
Copy link
Member Author

shilman commented Jul 12, 2019

Jeepers creepers!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-alpha.42 containing PR #7383 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jul 12, 2019
@dependencies dependencies bot mentioned this issue Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addon: docs BREAKING CHANGE
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
1 participant
@shilman