Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: docsOnly parameter generates rte #7956

Closed
atanasster opened this issue Sep 2, 2019 · 4 comments
Closed

Addon-docs: docsOnly parameter generates rte #7956

atanasster opened this issue Sep 2, 2019 · 4 comments

Comments

@atanasster
Copy link
Member

Describe the bug
using the new docsOnly parameter on a story generates a run time exception

To Reproduce
following story in an mdx file:

<Story name='docs-only-story' parameters={{ docsOnly: true } }>
  <Button onClick={action('clicked')}>preview source</Button>
</Story>

Screenshots
screenshot806

System:

 System:
    OS: macOS 10.14.1
    CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
  Binaries:
    Node: 12.1.0 - /usr/local/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.10.3 - /usr/local/bin/npm
  Browsers:
    Chrome: 76.0.3809.132
    Firefox: 66.0.5
    Safari: 12.0.1
@shilman
Copy link
Member

shilman commented Sep 2, 2019

It's an internal parameter, probably should be renamed with ___prefix. But that does look like a bug!

@shilman shilman added this to the 5.2.0 milestone Sep 2, 2019
@atanasster
Copy link
Member Author

the navigation is not expecting it to be hidden (the tree view and also the next/prev stories), found it while I was exploring #7844

@shilman shilman changed the title addons-doc: docsOnly parameter generates rte Addon-docs: docsOnly parameter generates rte Sep 2, 2019
@stale stale bot added the inactive label Sep 23, 2019
@shilman shilman modified the milestones: 5.2.0, 5.2.x Sep 23, 2019
@stale stale bot removed the inactive label Sep 23, 2019
@storybookjs storybookjs deleted a comment from stale bot Sep 23, 2019
@shilman shilman added the mdx label Oct 10, 2019
@stale
Copy link

stale bot commented Oct 31, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Oct 31, 2019
@stale
Copy link

stale bot commented Nov 30, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants