Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align docs content to the left #8004

Closed
patrickteivas opened this issue Sep 5, 2019 · 6 comments
Closed

Align docs content to the left #8004

patrickteivas opened this issue Sep 5, 2019 · 6 comments

Comments

@patrickteivas
Copy link
Contributor

patrickteivas commented Sep 5, 2019

Is your feature request related to a problem? Please describe.
When writing docs with addon-docs, content of .mdx file (Documentation file) starting from the center of window on FHD monitor resolution.

Describe the solution you'd like
Content aligned to the left, no need to increase max-width of the content block.

Are you able to assist bring the feature to reality?
Don't think so.

Additional context
Screenshot of content starting from the center (Like I described)
image
Screenshot of my idea
image

@patrickteivas patrickteivas changed the title Align docs content to left Align docs content to the left Sep 5, 2019
@patrickteivas
Copy link
Contributor Author

If this feature request will be accepted, I realized that display: flex on docs-root child div is responsible for this. I'm not expert in frontend development, but if just take this off, will it break other things?

display: -webkit-box;
display: -webkit-flex;
display: flex;

@shilman
Copy link
Member

shilman commented Sep 6, 2019

Cc @domyen who designed the current layout

@patrickteivas
Copy link
Contributor Author

cc @domyen so, what about it?

@domyen
Copy link
Member

domyen commented Sep 11, 2019

This happens because the content area should be aligned in the center of the docs area. Like so:
image

@shilman is adding a CSS class for folks to override the default styles with their own styling. It's unlikely alignment will be theme-able to keep the API tight.

@stale
Copy link

stale bot commented Oct 2, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Oct 2, 2019
@shilman
Copy link
Member

shilman commented Oct 2, 2019

Those classes should now be present in the SB Docs CSS in next (5.3.0-alpha.x). Documented here: https://github.com/storybookjs/storybook/blob/next/addons/docs/docs/theming.md#css-escape-hatches

Closing for now!

@shilman shilman closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants