Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content in ... menu is scrolling unnecessarily #8509

Closed
kaiyoma opened this issue Oct 22, 2019 · 5 comments
Closed

Content in ... menu is scrolling unnecessarily #8509

kaiyoma opened this issue Oct 22, 2019 · 5 comments

Comments

@kaiyoma
Copy link

kaiyoma commented Oct 22, 2019

As the title says. Can be seen on any recent version of Storybook. Here's a screencast showing the issue happening on 5.3.0-alpha.23:

https://imgur.com/a/s9bdQLu

@francismarcus
Copy link

I'l have a look :)

@francismarcus
Copy link

@kaiyoma Could you perhaps explain the issue further?
I am unable to reproduce any problem with the scrolling in the menu

@kaiyoma
Copy link
Author

kaiyoma commented Oct 22, 2019

Oh, the issue is that scrolling isn't necessary at all. If you make the menu a little bit taller, the scrollbar can go away. There's plenty of screen space left. 😄

@shilman
Copy link
Member

shilman commented Oct 24, 2019

Whoopee!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-alpha.27 containing PR #8545 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Oct 24, 2019
@shilman
Copy link
Member

shilman commented Nov 9, 2019

Jeepers creepers!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.6 containing PR #8545 that references this issue. Upgrade today to try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants