-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since ReactDOM 15.4 is out, the require hijack should be removed from version 2 #891
Labels
Comments
Is this issue still current? Please re-open if it's still something we need to do / fix 👍 |
This was referenced Jan 22, 2020
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue by imontiel
Monday Mar 20, 2017 at 21:00 GMT
Originally opened as storybook-eol/storyshots#90
Since ReactDOM 15.4.* is out, the require hijack should be removed so that stories that use overlays (such as react-bootstrap's
OverlayTrigger
) can be tested.Currently, in run_storyshots.js, the
ReactDOM
dependency is hijacked. This means any story that usesunstable_renderSubtreeIntoContainer
or any other function provided by ReactDOM (such as any of the functionality provided here) cannot be tested.I have a current work around where I invoke the cli directly:
I guess the easiest solution is to remove the hijack, change the ReactDOM dependency to
^15.4.0
and upversion to3.3.0
?The text was updated successfully, but these errors were encountered: