Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint failure on 5.3.1 #9423

Closed
zhigang1992 opened this issue Jan 14, 2020 · 2 comments
Closed

eslint failure on 5.3.1 #9423

zhigang1992 opened this issue Jan 14, 2020 · 2 comments
Labels
bug patch:yes Bugfix & documentation PR that need to be picked to main branch source-loader

Comments

@zhigang1992
Copy link

Describe the bug

To Reproduce

From https://gist.github.com/shilman/bc9cbedb2a7efb5ec6710337cbd20c0c#gistcomment-3135798

I think the eslint issue isn't yet fixed.

It won't show up at first, everything works.

After editing any file the error will show up.

It will keep showing up if you edit any other file that is not the one that's being reported.

Then after you edit this reported file, and refresh the error will go away... temporarily until you edit any other file again.

It's a really strange while frustrating problem. :(

System:

https://github.com/zhigang1992/bug-free-fiesta
https://loom.com/share/2dbe62f73c9c470e83f732a8c9aa381c

@zhigang1992
Copy link
Author

@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch source-loader labels Jan 14, 2020
@shilman
Copy link
Member

shilman commented Jan 14, 2020

Huzzah!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.3 containing PR #9417 that references this issue. Upgrade today to try it out!

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:yes Bugfix & documentation PR that need to be picked to main branch source-loader
Projects
None yet
Development

No branches or pull requests

2 participants