-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[addon-docs]: story-level viewMode specifier not working #9723
Comments
That's not the design of |
Thanks as always for the quick reply @shilman. Even if I remove --docs it doesn't behave as I'd expect. Same steps as above. It keeps whatever mode it had before, but doesn't force the another viewMode if set explicitly :/ |
Hmm. 🤔 Well that part's a bug then 😅 |
Let me know if I can help with anything, or if you can't replicate it, I can dive deeper into why it happens on my end. |
I can reproduce the issue as well with the following story:
If I'm currently browsing Storybook in docs and I go to this story, the view is not switched to "story". |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Facing the same issue. Configuration- export default {
title: 'Whatever',
parameters: {
viewMode: 'docs',
},
}; |
In my case, I want to hide the |
@matheo can you use |
@shilman we need to use the Figma addon, so it needs to be next to the Canvas right? Is there a way to load a Story in the docs view?
but I would need to specify docs instead Thanks in advance! |
@matheo OK yeah you can't use |
the way it works, is that --docs forces the viewMode to |
@shilman @ndelangen it would be nice to have |
Would be good to get this fixed! I can take a look if someone can point me in the right direction? |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Fixed in #10292 and available since |
Describe the bug
Maybe this is to be expected, but if I have --docs flag on, viewMode doesn't seem to be respected
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expect, that if I run --docs, and I explicitly set the viewMode to story, it should render the iframe with viewMode=story.
Code snippets
.storybook/preview.js
Button.stories.js
System:
Environment Info:
System:
OS: macOS 10.15.2
CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Binaries:
Node: 10.16.0 - /usr/local/bin/node
Yarn: 1.21.1 - ~/.yarn/bin/yarn
npm: 6.13.6 - /usr/local/bin/npm
Browsers:
Chrome: 79.0.3945.130
Safari: 13.0.4
The text was updated successfully, but these errors were encountered: