Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change react to a peer dependency for a11y-addon #9953

Closed
jmakGH opened this issue Feb 25, 2020 · 5 comments
Closed

Change react to a peer dependency for a11y-addon #9953

jmakGH opened this issue Feb 25, 2020 · 5 comments

Comments

@jmakGH
Copy link
Contributor

jmakGH commented Feb 25, 2020

Is your feature request related to a problem? Please describe.
The a11y-addon has react as a normal dependency at ^16.8.3 which leads to incompatibility issues for us as a consumer since we're using a pinned version of react@16.9.0. This is due to Storybook bundling the latest minor version of react, which is 16.12, resulting in there being two versions of React being used within the same tree which causes the following error to be thrown:

image (1)

Describe the solution you'd like
Is it possible to change react to being a peerDependency: * such as how the centered or knobs addons specify it? This keeps inline with the premise that Storybook/react functions independent of whatever version of React a consumer is using.

Describe alternatives you've considered
At this point, we can only drop the addon or implement our own version.

Are you able to assist bring the feature to reality?
Yes I can

@shilman
Copy link
Member

shilman commented Feb 26, 2020

@jmakGH sounds totally reasonable. PR welcome! perfect time for it too, since we're on 6.0 and this is probably (technically) a breaking change.

@jmakGH
Copy link
Contributor Author

jmakGH commented Feb 26, 2020

Thank you, PR submitted!

@stale
Copy link

stale bot commented Mar 18, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 18, 2020
@jmakGH
Copy link
Contributor Author

jmakGH commented Mar 22, 2020

Resolved by #9957

@jmakGH jmakGH closed this as completed Mar 22, 2020
@shilman
Copy link
Member

shilman commented Mar 23, 2020

ZOMG!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.28 containing PR #9957 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants