Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump react-split-pane version #1495

Merged
merged 2 commits into from
Jul 22, 2017
Merged

bump react-split-pane version #1495

merged 2 commits into from
Jul 22, 2017

Conversation

mrmartineau
Copy link
Contributor

this should fix issue #1352

Issue: #1352

What I did

Bump a version number

How to test

Run the storybook in IE11 and check that the side panel renders correctly

@mrmartineau
bump react-split-pane version
6fe09dd 
this should fix issue #1352
@usulpro
Copy link
Member

usulpro commented Jul 20, 2017

We have one more issue with react-split-pane: #1465
should we consider it as well?

@ndelangen
Copy link
Member

Consider closing it? What do you mean?

shilman
shilman approved these changes Jul 22, 2017
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (tho not in IE)

@shilman shilman merged commit 267ff2a into storybookjs:master Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen ndelangen approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrmartineau @usulpro @ndelangen @shilman