Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove webpack dependency #18651

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Jul 7, 2022

What I did

Removed webpack as a dependency from core-client as it isn't actually used by this package

Made webpack only a devDependency in core-common as it's only used in the tests

I want to remove this dependency because people who are using builder-vite don't need it

How to test

This should be covered by existing tests and shouldn't need any new tests

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

@nx-cloud
Copy link

nx-cloud bot commented Jul 7, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 792838f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf
Copy link
Member

yannbf commented Jul 7, 2022

Thanks for your PR @benmccann!
@ndelangen this seems relevant to the prebuilt manager work

@ndelangen
Copy link
Member

Cool! I'll deal with the merge conflicts upstream in future/base

@ndelangen ndelangen self-assigned this Jul 7, 2022
@ndelangen ndelangen merged commit d8c8c84 into storybookjs:next Jul 7, 2022
@benmccann benmccann deleted the rm-webpack branch July 7, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants