Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build addons-actions with ts-up #18775

Merged
merged 10 commits into from
Sep 27, 2022
Merged

Build addons-actions with ts-up #18775

merged 10 commits into from
Sep 27, 2022

Conversation

Saunved
Copy link
Contributor

@Saunved Saunved commented Jul 23, 2022

Issue: #18732

What I did

Followed the instructions from the above issue. Not very sure about the 'preview' setup, please let me know if it needs fixing.
The example was working correctly locally.

How to test

  • Is this testable with Jest or Chromatic screenshots? Will be tested with CI
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@Saunved Saunved requested a review from ndelangen July 23, 2022 20:27
@Saunved Saunved added the maintenance User-facing maintenance tasks label Jul 23, 2022
Base automatically changed from future/base to next July 25, 2022 10:37
@ndelangen ndelangen self-assigned this Jul 25, 2022
ndelangen and others added 3 commits July 26, 2022 10:30
@Saunved
Copy link
Contributor Author

Saunved commented Aug 11, 2022

@ndelangen I am stuck on this PR. I don't know why the test is failing. I tried to run the cra-essentials app locally with the next branch as well as this branch, and both yield the same results (and the same errors). Can you please help me out?

# Conflicts:
#	code/addons/actions/package.json
@ndelangen
Copy link
Member

@ndelangen
Copy link
Member

Looks like my fix didn't do anything to the CI failure. I'm not sure what's causing it.
It seems the manager part breaks throws as soon as the panel is opened.

# Conflicts:
#	code/addons/actions/package.json
@ndelangen ndelangen changed the title Feat/addons actions tsup Build addons-actions with ts-up Aug 25, 2022
# Conflicts:
#	code/addons/actions/package.json
# Conflicts:
#	code/addons/actions/package.json
@ndelangen
Copy link
Member

@ndelangen ndelangen merged commit b42f0ed into next Sep 27, 2022
@ndelangen ndelangen deleted the feat/addons-actions-tsup branch September 27, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants