Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add next-repro CLI command #18787

Merged
merged 7 commits into from
Jul 27, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jul 25, 2022

Issue: N/A

What I did

New repro command, initial work containing default CRA only. Both JS and TS to test concurrency optimizations:
image

That yields the following structure:

image

How to test

  1. yarn next-repro
  2. Assert the repro folder in the root of the monorepo
  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the maintenance User-facing maintenance tasks label Jul 25, 2022
@yannbf yannbf force-pushed the yann/sb-617-setting-up-the-generate-repro-script branch 2 times, most recently from 33888fb to 7c2ec27 Compare July 26, 2022 08:28
@yannbf yannbf force-pushed the yann/sb-617-setting-up-the-generate-repro-script branch from 7c2ec27 to d282324 Compare July 26, 2022 09:41
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yannbf yannbf merged commit b7522fb into next Jul 27, 2022
@yannbf yannbf deleted the yann/sb-617-setting-up-the-generate-repro-script branch July 27, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants