chore(cli): add uninstall deps to jsPackageManager #18900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
approved these changes
Aug 9, 2022
shilman
requested changes
Aug 9, 2022
| const { packageJson } = options; | ||
|
|
||
| dependencies.forEach((dep) => { | ||
| delete packageJson[dep]; |
There was a problem hiding this comment.
Shouldn't this delete from packageJson.dependencies or devDependencies?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
As part of automigrations we'll need to uninstall dependencies, so I added such functionality.
How to test
yarn test jspackagemanagerIf your answer is yes to any of these, please make sure to include it in your PR.