storyshots-puppeteer: add browserLaunchOptions to CommonConfig #18927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
I needed to pass browser launch options to puppeteer. Creating a custom browser instance and managing it shouldn't be necessary for just a simple config change and it made the tests far more complicated.
What I did
Simply added another option called
browserLaunchOptionsto theCommonConfig. I tried to merge the hard-coded config with the passed in one in a sensible way, but welcome any guidance into how that should be done. (e.g. right now the executablePath is allowed to be specified, but it just gets overrode by the default chromeExecutablePath, really it should be omitted from the allowed config if it isn't going to be used).How to test
Updated the documentation with the new option.