Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: auto-accept migrations when running generate-repros-next #18969

Merged
merged 1 commit into from
Aug 20, 2022
Merged

CLI: auto-accept migrations when running generate-repros-next #18969

merged 1 commit into from
Aug 20, 2022

Conversation

kylegach
Copy link
Contributor

Issue:

What I did

  1. Added --yes flag to init command run as part of generate-repros-next
  2. Made the automigrate step of init respect options.yes

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@kylegach kylegach added maintenance User-facing maintenance tasks cli labels Aug 19, 2022
@kylegach kylegach self-assigned this Aug 19, 2022
@kylegach kylegach requested a review from yannbf August 19, 2022 15:51
yannbf
yannbf approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this!

@yannbf yannbf changed the title generate-repros-next runs init w/ --yes CLI: auto-accept migrations when running generate-repros-next Aug 20, 2022
@yannbf yannbf merged commit afb1a56 into next Aug 20, 2022
@yannbf yannbf deleted the generate-repros-next-init-yes branch August 20, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees

@kylegach kylegach

Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylegach @yannbf