Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Set resolve.preserveSymlinks based on env vars #19039

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

tmeasday
Copy link
Member

Similar to how we do in webpack.

  • I think core-common is the right place for this util?

How to test

A basic linked Vite sandbox should now work without modification.

@tmeasday tmeasday requested a review from IanVS August 29, 2022 01:10
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman changed the title Set resolve.preserveSymlinks in Vite based on env vars Vite: Set resolve.preserveSymlinks in Vite based on env vars Aug 29, 2022
@shilman shilman changed the title Vite: Set resolve.preserveSymlinks in Vite based on env vars Vite: Set resolve.preserveSymlinks based on env vars Aug 29, 2022
@shilman shilman merged commit eaac795 into next Aug 29, 2022
@shilman shilman deleted the symlinks-in-vite branch August 29, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants