Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add previewHead and previewBody to StorybookConfig interface #19047

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

mandarini
Copy link
Contributor

@mandarini mandarini commented Aug 29, 2022

Issue:

previewHead does not exist in the StorybookConfig interface. This results in type errors when using TypeScript configuration (main.ts). See screenshot:

Screenshot 2022-08-29 at 8 03 31 PM

What I did

I added previewHead and previewBody in the StorybookConfig interface.

This was raised in this issue on the Nx side.

@mandarini mandarini force-pushed the fix/update-storybook-config-type branch from a970f34 to 5782f00 Compare August 29, 2022 17:16
@mandarini mandarini force-pushed the fix/update-storybook-config-type branch from 5782f00 to 3b0a999 Compare August 30, 2022 08:34
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mandarini !!!! Looks great with a small change

code/lib/core-common/src/types.ts Outdated Show resolved Hide resolved
code/lib/core-common/src/types.ts Outdated Show resolved Hide resolved
@shilman shilman changed the title fix: add previewHead and previewBody to StorybookConfig interface Core: Add previewHead and previewBody to StorybookConfig interface Aug 30, 2022
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch core typescript maintenance User-facing maintenance tasks and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Aug 30, 2022
@shilman shilman merged commit b63d349 into storybookjs:next Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core maintenance User-facing maintenance tasks typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants