-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-backgrounds: Move stories into addon #19085
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
changed the title
add stories from official-example
move addon-background' stories into addons/actions/template/stories
Sep 1, 2022
ndelangen
changed the title
move addon-background' stories into addons/actions/template/stories
move addon-background' stories into addons/viewports/template/stories
Sep 1, 2022
shilman
reviewed
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.stories.ts
=> .stories.js
(I think)
shilman
requested changes
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we hook this up to chromatic as part of the PR
ndelangen
changed the title
move addon-background' stories into addons/viewports/template/stories
move addon-background' stories into addons/backgrounds/template/stories
Sep 2, 2022
@shilman should start to work with the changes we made on next. |
ndelangen
force-pushed
the
norbert/sb-575-addon-backgrounds
branch
from
September 2, 2022 10:38
2cb0d8f
to
7f71e35
Compare
shilman
changed the title
move addon-background' stories into addons/backgrounds/template/stories
Examples: Move addon-backgrounds stories into addon
Sep 2, 2022
shilman
changed the title
Examples: Move addon-backgrounds stories into addon
Addon-backgrounds: Move stories into addon
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code/addons/backgrounds/template/stories