Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-backgrounds: Move stories into addon #19085

Merged
merged 6 commits into from
Sep 2, 2022

Conversation

ndelangen
Copy link
Member

  • add generic stories for addon-background in code/addons/backgrounds/template/stories
  • remove stories for background everywhere else

@ndelangen ndelangen self-assigned this Sep 1, 2022
@ndelangen ndelangen added maintenance User-facing maintenance tasks addon: backgrounds labels Sep 1, 2022
@ndelangen ndelangen changed the title add stories from official-example move addon-background' stories into addons/actions/template/stories Sep 1, 2022
@ndelangen ndelangen changed the title move addon-background' stories into addons/actions/template/stories move addon-background' stories into addons/viewports/template/stories Sep 1, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.stories.ts => .stories.js (I think)

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we hook this up to chromatic as part of the PR

@ndelangen ndelangen changed the title move addon-background' stories into addons/viewports/template/stories move addon-background' stories into addons/backgrounds/template/stories Sep 2, 2022
@ndelangen
Copy link
Member Author

@shilman should start to work with the changes we made on next.

@ndelangen ndelangen force-pushed the norbert/sb-575-addon-backgrounds branch from 2cb0d8f to 7f71e35 Compare September 2, 2022 10:38
@shilman shilman changed the title move addon-background' stories into addons/backgrounds/template/stories Examples: Move addon-backgrounds stories into addon Sep 2, 2022
@shilman shilman changed the title Examples: Move addon-backgrounds stories into addon Addon-backgrounds: Move stories into addon Sep 2, 2022
Base automatically changed from norbert/sb-573-addon-actions to next September 2, 2022 15:24
@shilman shilman merged commit 7f4c7a3 into next Sep 2, 2022
@shilman shilman deleted the norbert/sb-575-addon-backgrounds branch September 2, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: backgrounds maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants