Vite: cleanup custom plugins #19087
Merged
Vite: cleanup custom plugins #19087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was fixed in vite prior to 3.0, which is the lowest version we support now.
This will make them easier to understand in debug logs, for instance.
We need this to support the new object hooks
joshwooding
approved these changes
Sep 2, 2022
|
Is it possible that this is legitimately broken by vite? https://www.chromatic.com/build?appId=5a375b97f4b14f0020b0cda3&number=27316 The library story itself seems fine: https://www.chromatic.com/component?appId=5a375b97f4b14f0020b0cda3&csfId=addons-interactions-examples-accountform--standard-fail-hover&buildNumber=27316&k=6311e20b836c095043ed053c-1200-interactive-true&h=9&b=-6 |
|
No this looks like a regression from some recent interactions work. I believe @ghengeveld is aware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Our custom Vite plugins were a bit disorganized, and some are no longer needed.
What I did
I removed the
no-foucplugin, which was only needed in versions of Vite < 3, but we only support Vite 3+ now. I also removed the unusedreact-docgenplugin from the builder (it's in the react framework now instead).This also moves all plugins in the builder to
/plugins, and renames all plugins with a common naming convention ofstorybook:name-of-plugin, to aid in identification in error logs. And a major version release seemed like a good time to make that change.Lastly, this incorporates the same change as storybookjs/builder-vite#490, to avoid problems when building typescript with the latest versions of Vite.
How to test
Fire up a vite sandbox, confirm it still works, and that you don't see a flash of unstyled content when the page is first loading up.