Deps: Upgrade react-element-to-jsx-string and react-inspector for React 18 #19104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
This was referenced Sep 5, 2022
NiGhTTraX
added a commit
to NiGhTTraX/ts-monorepo
that referenced
this pull request
Nov 12, 2022
Latest v6.x is not compatible with React@18: storybookjs/storybook#19104 storybookjs/storybook#18559
|
Hello 👋 It seems this PR has been included in the v7 alpha, would that be possible to cherry pick it in the 6.5 branch ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #18559 #18349
Reference: #14119
Several dependencies need to be updated to avoid peer dependency warnings for react 18.
Closes #18701
Closes #17076
What I did
I updated react-element-to-jsx-string and react-inspector to versions that support React 18. They are backwards compatible with previous versions of react as well.
How to test
CI.