-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor bootstrap+sandbox into "task" framework #19275
Refactor bootstrap+sandbox into "task" framework #19275
Conversation
Plus rename a couple others
…ocument-maintenance-scripts
…ocument-maintenance-scripts
…ocument-maintenance-scripts
@tmeasday I think we could/should change the way we invoke the task from:
to:
|
I also opened a PR to remove the duplicate yarn installation: |
…ocument-maintenance-scripts
I agree but I kind of want to merge this. Perhaps a follow up PR later? I was thinking to change the options mechanism to allow certain "positional" options. But we'd also need to tweak all the docs etc. |
@ndelangen I ended up doing that in this PR too:cbead1a |
Oh I see you did something different. |
Refactor sandbox into
yarn task
so that it is all of one piece. In particular:yarn sandbox
turning it into thesandbox
taskyarn bootstrap
and./bootstrap.sh
turning them into thecompile
taskAs documented
yarn start
will:code
scripts
yarn task
will:scripts
Note that yarn task only installs in
code
if you choose theinstall
task. If you've never installed, this will definitely happen, but if your install is out of date, this might trip you up. This is documented.I've tried to get as many places we referenced bootstrap as possible but I'm sure I've missed things. We will definitely need to do more cleanup once we've finished deleting examples.