-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): disable ngcc when not needed #19307
Conversation
This thread also discusses why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This totally makes sense
I left some comments 🙂
@ndelangen and @kroeder: Contributing to Storybook is such a great experience 💯 . Thank you for the quick follow-up 🙌🏻 . We will definitely do that again if we have the opportunity 😍 |
Would it be possible to patch this into storybook v6, since vNext is not yet released? |
@DanielRose I recommend trying the beta release 👍 |
@ndelangen I'm sorry, but I'm not going to deploy a beta release on a production system. |
Hi @DanielRose , Maybe another idea ? |
Issue:
What I did
If you run postInstall ngcc, you don't have to run it every time you start a storybook instance.
If you have a monorepo project with a lot of storybook settings and tests, this can cause lockouts and a message like this:
“Another process, with id 5197, is currently running ngcc.”
We're adding an optional parameter to the angular configuration to disable ngcc. Ngcc is enabled by default
How to test
If your answer is yes to any of these, please make sure to include it in your PR.