-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Fix addon URL escaping in manager #19375
UI: Fix addon URL escaping in manager #19375
Conversation
Hmm I'm having second thoughts on this remapping to different files thing... Perhaps all I need to do is escape the URL? @tmeasday you said that "the files are there".. Maybe I can make it work by tweaking the html a bit. |
OK, I think if found a much better solution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from typo in function name
@ndelangen I think this change might have broken Windows support. See #19534. Or maybe not, but something in alpha.37 caused it to break, and this looks suspicious. Maybe by encoding backslashes, we're not able to convert it to a posix path later on using |
|
The URL injected into the manager for addons were not escaped properly causing them to 404 on some hosting platforms.
I added escaping for these URLs.