Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Move default cache dir to node_modules/.cache #19384

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Oct 7, 2022

Issue: N/A

What I did

It's always kind of bugged me that the default storybook vite cache is not in node_modules/.cache. It is this way because the default vite cache is node_modules/.vite, but it means that those of us used to getting into a clean state by rm -rf node_modules/.cachce also need to know about this other special folder that needs to be cleaned out too.

This PR moves the default cache directory into .cache, following the law of least surprise. :)

I also added a note to the migration guide, though I don't expect this break anyone's projects.

Lastly, I cleaned up a section of the migration guide which previously had its table-of-contents entry removed, but the content itself was still there.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

MIGRATION.md Show resolved Hide resolved
@yannbf yannbf merged commit 223fcd9 into next Oct 10, 2022
@yannbf yannbf deleted the vite/cache-dir branch October 10, 2022 14:40
@yannbf
Copy link
Member

yannbf commented Oct 10, 2022

Thanks @IanVS !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants