Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

direct logs to stdout #19434

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Conversation

ohana54
Copy link
Contributor

@ohana54 ohana54 commented Oct 11, 2022

Issue: #14621

What I did

Changed the default log output to stdout.
For npm, making the default stderr makes sense (as the maintainers claim), but I believe this is not true for storybook.

I didn't add tests as we mock npmlog in the logger tests, let me know if we need to add a test and what would be the preferred approach.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf
Copy link
Member

yannbf commented Oct 17, 2022

Hey @ohana54 thanks for your contributiont! @ndelangen would you mind taking a look at this? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants