Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Add a TypeScript check task and configure ci to run it #19471

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Build: Add a TypeScript check task and configure ci to run it #19471

merged 3 commits into from
Oct 13, 2022

Conversation

ndelangen
Copy link
Member

  • Add a check task
  • Add it to the CI config

@ndelangen ndelangen self-assigned this Oct 13, 2022
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Oct 13, 2022
@shilman shilman changed the title add a check task and configure the ci to run it Build: Add a TypeScript check task and configure the ci to run it Oct 13, 2022
@shilman shilman changed the title Build: Add a TypeScript check task and configure the ci to run it Build: Add a TypeScript check task and configure ci to run it Oct 13, 2022
shilman
shilman approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @ndelangen 🚀

@ndelangen ndelangen merged commit 9d9f9f0 into next Oct 13, 2022
@ndelangen ndelangen deleted the tech/add-check-ci-step branch October 13, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@kasperpeulen kasperpeulen Awaiting requested review from kasperpeulen

Assignees

@kasperpeulen kasperpeulen

@ndelangen ndelangen

Labels
build Internal-facing build tooling & test updates typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndelangen @shilman @kasperpeulen