Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove storyStore.getSelection #19491

Merged
merged 2 commits into from
Oct 17, 2022
Merged

remove storyStore.getSelection #19491

merged 2 commits into from
Oct 17, 2022

Conversation

ndelangen
Copy link
Member

remove storyStore.getSelection

@ndelangen ndelangen self-assigned this Oct 14, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Oct 14, 2022
IanVS
IanVS approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. 👍

tmeasday
tmeasday approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@ndelangen ndelangen merged commit 36e2503 into next Oct 17, 2022
@ndelangen ndelangen deleted the deprecate/getSelection branch October 17, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS approved these changes

@tmeasday tmeasday tmeasday approved these changes

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndelangen @tmeasday @IanVS