Add missing addons/docs dependency for fs-extra #19493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: line 1 of addons/docs/src/preset.js is
import fs from 'fs-extra';
, butfs-extra
is missing from addons/docs’ package.json.What I did
i added
"fs-extra": "^9.0.1",
to the package.jsondependencies
(the same version string that i found elsewhere, e.g. in core-common)How to test
i ran into this issue when trying to upgrade to storybook
v7.0.0-alpha.37
in a codebase using the vite builder and yarn v3.2.4. the specific error is:i worked around it by adding the dependency via
packageExtensions
in my.yarnrc.yml
. this fix can be verified by checking to see that the error above no longer occurs when runningstorybook
using the vite builder on yarn. but it’s also self-evidently correct, so there’s that.note that i ran into the same kind of issue from
@storybook/common-core
requiring@storybook/react-vite
even though it isn‘t in its deps, but i think that might be a dynamic require that comes from.storybook/main.js
’sframework.name
, so i’m not sure how that should be resolved.