Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .git folder when generating repros #19535

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Remove .git folder when generating repros #19535

merged 1 commit into from
Oct 19, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Oct 19, 2022

Issue: N/A

What I did

When generating repros, .git folders should not be generated, else the umbrella repo gets confused.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the build Internal-facing build tooling & test updates label Oct 19, 2022
shilman
shilman approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shilman shilman merged commit 8b140d2 into next Oct 19, 2022
@shilman shilman deleted the chore/remove-git-repos-in-repro branch October 19, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannbf @shilman