Ensure preview annotations are resolved relative to the cwd #19594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
added
bug
patch:yes
tmeasday
changed the title
2 tasks
tmeasday
commented
Oct 25, 2022
shilman
approved these changes
Oct 25, 2022
| @@ -125,21 +125,24 @@ export default async ( | |||
| path.join(__dirname, '..', '..', 'templates', 'virtualModuleEntry.template.js') | |||
| ); | |||
|
|
|||
| previewAnnotations.forEach((previewAnnotationFilename: any) => { | |||
| previewAnnotations.forEach((previewAnnotationFilename: string | undefined) => { | |||
| if (!previewAnnotationFilename) return; | |||
There was a problem hiding this comment.
No idea. Previously it was just being cast to any and then used as a string
|
I don't think we have any meaningful tests for generated webpack configs, outside of running the Storybook. So the test would be getting a v6 store sandbox. |
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: (when sandbox running in v6 mode, although this was a more general issue):
What I did
Make entry point filenames not have
/in them.How to test
Run v6 sandbox. Note it won't run (2nd PR coming) but it should start.