Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bundle lib/preview-web with ts-up #19655

Merged
merged 9 commits into from
Oct 28, 2022
Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Oct 27, 2022

related #18732

With much thanks to @javier-arango whom created #19319 first

@ndelangen ndelangen self-assigned this Oct 27, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Oct 27, 2022
@ndelangen
Copy link
Member Author

ndelangen commented Oct 28, 2022

The unit tests are failing because the test is reaching too deep into another package IMHO.
I'll see if I can make the import a relative import without importing by package name, to make it work.

If that works I can also remove the extra entry-points.

@socket-security
Copy link

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
es5-ext@0.10.62 (added) postinstall code/package.json via @compodoc/compodoc@1.1.19, pdfmake@0.2.6, @foliojs-fork/linebreak@1.1.1, brfs@2.0.2, static-module@3.0.4, scope-analyzer@2.1.2, es6-map@0.1.5,scripts/package.json via @compodoc/compodoc@1.1.19, pdfmake@0.2.6, @foliojs-fork/linebreak@1.1.1, brfs@2.0.2, static-module@3.0.4, scope-analyzer@2.1.2, es6-map@0.1.5
🧌 Troll package added

This package is a joke. You should not use it in production.

Package Note Location
es5-ext@0.10.62 (added) This package prints a protestware console message on install regarding Ukraine for users with Russian language locale code/package.json via @compodoc/compodoc@1.1.19, pdfmake@0.2.6, @foliojs-fork/linebreak@1.1.1, brfs@2.0.2, static-module@3.0.4, scope-analyzer@2.1.2, es6-map@0.1.5,scripts/package.json via @compodoc/compodoc@1.1.19, pdfmake@0.2.6, @foliojs-fork/linebreak@1.1.1, brfs@2.0.2, static-module@3.0.4, scope-analyzer@2.1.2, es6-map@0.1.5
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 1 new install script detected
Telemetry ✅ no new telemetry
Troll package ⚠️ 1 new troll package detected
Malware ✅ no new malware
Native code ✅ no new native modules
Bin Script Confusion ✅ no new bin script confusions
Bin script shell injection ✅ no new bin script shell injection
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore es5-ext@0.10.62

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

ndelangen and others added 4 commits October 28, 2022 14:16
Co-authored-by: Tom Coleman <tom@chromatic.com>
@ndelangen ndelangen changed the title migrate preview-web to tsup Build: Bundle lib/preview-web with ts-up Oct 28, 2022
@ndelangen ndelangen merged commit 56c882f into next Oct 28, 2022
@ndelangen ndelangen deleted the tech/bundle-preview-web branch October 28, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant