-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML: Add html-vite
framework
#19698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems great to me. I'm not sure what's up with CircleCI though...
It seems like there's a problem happening in CI:
I'm not sure actually the best way to debug this, until the sandbox is merged and published. @shilman what's the best order of operations when adding a new framework? Does the repro need to be added first in a separate PR? |
Usually there's a manual GitHub workflow maintainers can trigger pointing to a certain branch, that will generate repros from that branch, which should result in it being available in CI. However it only works for branches on the repo, not forks. cc @yannbf @kasperpeulen this PR might affect/be affected by your current CI work. |
@JReinhold Correct, I added a comment about that. |
I was hoping to bring this up to date with
|
# Conflicts: # .circleci/config.yml
Branch is up to date now, with the necessary code changes to get things working! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! One potential change
@@ -0,0 +1,8 @@ | |||
// exports for builder-vite | |||
export { createChannel as createPostMessageChannel } from '@storybook/channel-postmessage'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we don't need any of these exports anymore except the StorybookConfig
type. @IanVS any other changes we need to make to get this working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, you're right, we can remove the extra re-exports now. 👍
"@storybook/node-logger": "7.0.0-alpha.56", | ||
"@storybook/preview-web": "7.0.0-alpha.56", | ||
"magic-string": "^0.26.1", | ||
"vite": "3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to open this up to allow version 4, but we can do that in another PR, for all the vite frameworks.
Thanks @GregLahaye !!! This is a great contribution 🙌 |
@GregLahaye, thanks for this amazing contribution, one small item related to this pull request. If you could jump into our Discord Server and message me directly (same username)? Looking forward to hearing from you. Hope you have a great week. Stay safe |
Issue: N/A
What I did
Added
html-vite
framework, along with repro templates.I've mostly based this framework off the
web-components-vite
framework, happy to implement feedback.How to test
Had trouble creating a sandbox locally as it attempts to pull
@storybook/html-vite
from the Yarn registry instead of locally when linking, but the repro works fine.