Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Enable Scorecard Github Action and Badge #19755

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Chore: Enable Scorecard Github Action and Badge #19755

merged 2 commits into from
Jan 13, 2023

Conversation

joycebrum
Copy link
Contributor

Issue: Closes #19743

What I did

  • I've configured the Scorecard Github Action
  • I've added the Scorecard Badge to the README file

How to test

OBS: The badge when added to the forked repo does not show the real project score, being always a little lower.

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

Signed-off-by: Joyce Brum <joycebrum@google.com>
Signed-off-by: Joyce Brum <joycebrum@google.com>
@shilman shilman added maintenance User-facing maintenance tasks build Internal-facing build tooling & test updates and removed maintenance User-facing maintenance tasks labels Nov 8, 2022
@shilman
Copy link
Member

shilman commented Nov 8, 2022

Hi @joycebrum ! Thanks so much for making this PR. I want to review the security issues raised by the tool & see whether these are things we want to optimize for before merging. But overall it looks great and I'm hoping we can get it in this week or next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Enable Scorecard Github Action and Badge
4 participants